Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix workflows lint & test #1344

Merged

Conversation

TartanLeGrand
Copy link
Contributor

This PR introduces significant improvements to our GitHub Actions workflow to optimize the process for linting and testing our Helm charts. 🚀

Key Changes:

  • 🧹 Streamlined Workflow: Refined the steps in our CI pipeline to reduce redundancy. This includes better handling of environment variables and outputs.
  • 🔧 Fixed Chart Directory Issues: Corrected the chart directory, ensuring that ct list-changed and ct lint operate on the correct directories.

Expected Benefits:

  • 🛠️ Enhanced Reliability: More accurate linting and testing will help prevent issues from making it to production, boosting our overall deployment reliability.
  • 📊 Better Visibility: The debug enhancements will provide deeper insights into the CI process, making it easier to identify and fix issues early.

Looking Forward:

  • I plan to monitor the impact of these changes on our CI performance closely and will make further adjustments as needed based on the outcomes.

Request for Feedback:

  • 🔄 I'm open to suggestions on how to further refine our CI pipeline and would love to hear about any additional tools or practices that could be integrated to improve our workflow.

Thank you for reviewing these workflow enhancements! Your feedback is invaluable as we continue to improve our CI/CD processes. 🌟

@TartanLeGrand TartanLeGrand force-pushed the ci/fix/workflows/test-lint branch from dd724b1 to 6950bd6 Compare June 30, 2024 16:24
@TartanLeGrand TartanLeGrand force-pushed the ci/fix/workflows/test-lint branch from 6950bd6 to 77d977e Compare June 30, 2024 16:24
@TartanLeGrand
Copy link
Contributor Author

👀 Merge this before continue the #1343

@Mokto
Copy link
Contributor

Mokto commented Jun 30, 2024

I'm afraid this will break a lot of things.

release-please-config.json I'm pretty sure you have to change, but I think there will be a few others.

@TartanLeGrand
Copy link
Contributor Author

I'm afraid this will break a lot of things.

release-please-config.json I'm pretty sure you have to change, but I think there will be a few others.

Yes, you have right !

I have do this in this PR:

https://github.com/sentry-kubernetes/charts/pull/1343/files#diff-c55d4dcb68c348b2c06d263819702fbce72eeeb35b662956d02049a5a18fcf2b

I go to fix !

@Mokto
Copy link
Contributor

Mokto commented Jul 2, 2024

You are also missing a change in the deployment workflow.

@Mokto
Copy link
Contributor

Mokto commented Jul 2, 2024

The tests are failing.

@TartanLeGrand
Copy link
Contributor Author

The tests are failing.

Yes because the chart is already broken 😄 :

#1315

@Mokto Mokto merged commit 4010751 into sentry-kubernetes:develop Jul 2, 2024
1 of 2 checks passed
@Mokto
Copy link
Contributor

Mokto commented Jul 2, 2024

Ok then i'll merge it and wait for your changes on the 24.6.0 branch

@Mokto
Copy link
Contributor

Mokto commented Jul 10, 2024

@TartanLeGrand #1357 the release flow is broken.

@TartanLeGrand TartanLeGrand deleted the ci/fix/workflows/test-lint branch July 10, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants